netdev - Re: panic 2.6.27-rc3-git2, qdisc_dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Aug 2008 15:16:35 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Denys Fedoryshchenko <denys@...p.net.lb>
Cc:	netdev@...r.kernel.org
Subject: Re: panic 2.6.27-rc3-git2, qdisc_dequeue_head

On Sun, Aug 17, 2008 at 03:50:01PM +0300, Denys Fedoryshchenko wrote:
> On Sunday 17 August 2008, Jarek Poplawski wrote:
> 
> > Denys, I would like to be sure: do you mean here the last patch
> > attached below? So, the alternative shaper works with previous
> > patches, but not this one? If so, than no need to test this patch
> > anymore, only confirm this, please.
> No.
> Alternative shaper didn't work without applying latest patch (just i had old 
> kernel, and i decide just to try alternative shaper).
> 
> Latest warning with all patches applied. I will test alternative shaper with 
> all patches applied now.
> 

I think it would be better to test first only with patches:
take #3, patch #1, patch #2 (and of these 2 from earlier thread).

This last patch, let's call it patch #4, can wait.

If there are oopses please try to add to them this one:

Jarek P.

--- (patch #5)

 net/sched/sch_api.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index c25465e..5fdd1e2 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -694,6 +694,9 @@ static int qdisc_graft(struct net_device *dev, struct Qdisc *parent,
 
 		err = -EINVAL;
 
+		if (dev->flags & IFF_UP)
+			dev_deactivate(dev);
+
 		if (cops) {
 			unsigned long cl = cops->get(parent, classid);
 			if (cl) {
@@ -703,6 +706,9 @@ static int qdisc_graft(struct net_device *dev, struct Qdisc *parent,
 		}
 		if (!err)
 			notify_and_destroy(skb, n, classid, old, new);
+
+		if (dev->flags & IFF_UP)
+			dev_activate(dev);
 	}
 	return err;
 }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html