netdev - Re: [PATCH] sch_prio: Use return value from inner qdisc requeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 Aug 2008 22:45:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jussi.kivilinna@...et.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] sch_prio: Use return value from inner qdisc requeue

From: Jussi Kivilinna <jussi.kivilinna@...et.fi>
Date: Fri, 08 Aug 2008 01:10:14 +0300

> Use return value from inner qdisc requeue when value returned isn't
> NET_XMIT_SUCCESS, instead of always returning NET_XMIT_DROP.
> 
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...et.fi>

Applied, thanks Jussi.

I added the following followon patch afterwards:

sch_prio: Use NET_XMIT_SUCCESS instead of "0" constant.

Signed-off-by: David S. Miller <davem@...emloft.net>
---
 net/sched/sch_prio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
index 7cdc3e6..a6697c6 100644
--- a/net/sched/sch_prio.c
+++ b/net/sched/sch_prio.c
@@ -113,7 +113,7 @@ prio_requeue(struct sk_buff *skb, struct Qdisc* sch)
 	if ((ret = qdisc->ops->requeue(skb, qdisc)) == NET_XMIT_SUCCESS) {
 		sch->q.qlen++;
 		sch->qstats.requeues++;
-		return 0;
+		return NET_XMIT_SUCCESS;
 	}
 	if (net_xmit_drop_count(ret))
 		sch->qstats.drops++;
-- 
1.5.6.5.GIT

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html