netdev - Re: [PATCH]: Schedule correct qdisc in watchdog.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080818.023105.01989851.davem@davemloft.net>
Date:	Mon, 18 Aug 2008 02:31:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH]: Schedule correct qdisc in watchdog.

From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 18 Aug 2008 09:10:12 +0000

> Yes, this was one of the reasons, but not the only one, and my oldbie
> version of this fix could be found here as "02-fix1.patch":
> 
> http://permalink.gmane.org/gmane.linux.network/103039

This is what I get for failing to be able to follow that
flurry of patches :)  I'll apply your version in the
end, thanks.

> It's a bit different, because I think wd->qdisc can probably
> point to the noop_qdisc (if it's the root qdisc).

noop_qdisc does not use the watchdogs as far as I can see.

But, if we are in dev_deactivate() state, root qdisc can
be &noop_qdisc and scheduling that is fine and just a nop.

> Anyway this kind of change is necessary here, and everywhere where
> netif_schedule() could be called (I've found sch_cbq.c only).

Indeed.

I can't find any other cases that would matter.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html