netdev - Re: [PATCH] atl1: disable TSO by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080819175334.28dc1c8e@osprey.hogchain.net>
Date:	Tue, 19 Aug 2008 17:53:34 -0500
From:	Jay Cliburn <jacliburn@...lsouth.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, link@...gy.org, ian@...fray.co.uk,
	csnook@...hat.com, jie.yang@...eros.com, m@...oston.org,
	davem@...emloft.net
Subject: Re: [PATCH] atl1: disable TSO by default

On Tue, 19 Aug 2008 23:10:37 +1000
Herbert Xu <herbert@...dor.apana.org.au> wrote:

> Jay Cliburn <jacliburn@...lsouth.net> wrote:

> >        netdev->features |= NETIF_F_LLTX;
> 
> Another new driver using LLTX, this is not good when we're trying
> to get rid of it.

The atl1 driver was merged in the spring of 2007, so I'm not sure I
consider it new (but your kernel development time horizon is undoubtedly
*way* longer than mine, so you may indeed consider it new). It was
basically a vendor driver that we modified to conform to kernel coding
standards. It started life, we believe, as pretty much a clone of the
e1000 driver circa 2005, so that's likely where it's use of LLTX
came from.

> 
> Perhaps we could just kill it by ignoring the LLTX flag and always
> grabbing the xmit lock.  That should be safe as long as none of these
> drivers grab the xmit lock within their private locks.

I'd be happy to gin up a patch if you could point me to a driver that
implements properly what you're asking.

Thanks,
Jay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html