netdev - Re: [PATCH] atl1: disable TSO by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080819231716.GA10741@gondor.apana.org.au>
Date:	Wed, 20 Aug 2008 09:17:16 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	jacliburn@...lsouth.net, jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, link@...gy.org, ian@...fray.co.uk,
	csnook@...hat.com, jie.yang@...eros.com, m@...oston.org
Subject: Re: [PATCH] atl1: disable TSO by default

On Tue, Aug 19, 2008 at 03:58:45PM -0700, David Miller wrote:
>
> > The atl1 driver was merged in the spring of 2007, so I'm not sure I
> > consider it new (but your kernel development time horizon is undoubtedly
> > *way* longer than mine, so you may indeed consider it new). It was
> > basically a vendor driver that we modified to conform to kernel coding
> > standards. It started life, we believe, as pretty much a clone of the
> > e1000 driver circa 2005, so that's likely where it's use of LLTX
> > came from.
> 
> You'll have to forgive us, as we often have a knee jerk reaction
> to seeing LLTX anywhere :-)

Heh, it's like seeing a fly in your soup :)

However, this does seem to be proliferating to some extent although
I picked on the wrong driver.  The one I saw that was new is actually
drivers/net/atl1e which seems to have copied the same code across.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html