netdev - Re: [PATCH]: Schedule correct qdisc in watchdog.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080819065958.GB4376@ff.dom.local>
Date:	Tue, 19 Aug 2008 06:59:58 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	denys@...p.net.lb, netdev@...r.kernel.org
Subject: Re: [PATCH]: Schedule correct qdisc in watchdog.

On Mon, Aug 18, 2008 at 08:54:27PM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Mon, 18 Aug 2008 11:35:31 +0000
> 
> > pkt_sched: Add lockdep annotation for qdisc locks
> > 
> > Qdisc locks are initialized in the same function, qdisc_alloc(), so
> > lockdep can't distinguish tx qdisc lock from rx and reports "possible
> > recursive locking detected" when both these locks are taken eg. while
> > using act_mirred with ifb. This looks like a false positive. Anyway,
> > after this patch these locks will be reported more exactly.
> > 
> > Reported-by: Denys Fedoryshchenko <denys@...p.net.lb>
> > Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
> 
> Applied, thanks Jarek.
> 
> I suspect we need to apply this lock annotation to the locks
> in the static qdiscs &noop_qdisc and &noqueue_qdisc.
> 

I guess, we currently don't need this. At least ingress checks and
skipps acting for &noop_qdisc. I'd prefer to see some lockdep warning
first, or maybe you could show some scenario?

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html