netdev - Re: qdisc_enqueue, NET_XMIT_SUCCESS and kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080819131139.GA5754@gondor.apana.org.au>
Date:	Tue, 19 Aug 2008 23:11:39 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	David Miller <davem@...emloft.net>, jussi.kivilinna@...et.fi,
	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: qdisc_enqueue, NET_XMIT_SUCCESS and kfree_skb

On Tue, Aug 19, 2008 at 03:08:57PM +0200, Patrick McHardy wrote:
>
> >Another possibility would to replace requeue by a peek+force_dequeue
> >interface, where you can peek at the next packet, and you could then
> >dequeue that particular packet if you're satisfied.
> 
> That would be fine for TBF since it only needs to check whether
> the current packet exceeds the limit and reschedule otherwise.
> HFSC OTOH really needs to know the length of the next packet for
> calculating the deadline.

You mean a peek interface is insufficient for HFSC? Could you
elaborate?

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html