netdev - Re: [patch] ipvsadm: use strtoul to convert ip addresses from hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4845fc0808200330lc1cad87ya94eb73da9b4c175@mail.gmail.com>
Date:	Wed, 20 Aug 2008 12:30:41 +0200
From:	"Julius Volz" <juliusv@...gle.com>
To:	"Simon Horman" <horms@...ge.net.au>
Cc:	"Vince Busam" <vbusam@...gle.com>, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, wensong@...ux-vs.org
Subject: Re: [patch] ipvsadm: use strtoul to convert ip addresses from hex

On Wed, Aug 20, 2008 at 7:44 AM, Simon Horman <horms@...ge.net.au> wrote:
> The ip addresses that come out of /proc/net/ip_vs_conn as integers
> are in hex not decimal.
>
> Without this change most IP addresses reported as integers end up being
> 0.0.0.0.
>
> This change is against the development code ipvsadm-1.25-nl-4 from
> http://sixpak.org/vince/google/ipvsadm/ . It is not relevant to
> ipvsadm-1.24, the current released version.
>
> Signed-off-by: Simon Horman <horms@...ge.net.au>
>
> Index: ipvsadm-1.25-nl-4/ipvsadm.c
> ===================================================================
> --- ipvsadm-1.25-nl-4.orig/ipvsadm.c    2008-08-20 15:16:18.000000000 +1000
> +++ ipvsadm-1.25-nl-4/ipvsadm.c 2008-08-20 15:16:39.000000000 +1000
> @@ -1212,9 +1212,9 @@ static void print_conn(char *buf, unsign
>                inet_pton(AF_INET, temp2, &vaddr.ip);
>                inet_pton(AF_INET, temp3, &daddr.ip);
>        } else {
> -               caddr.ip = (__u32) htonl(atoi(temp1));
> -               vaddr.ip = (__u32) htonl(atoi(temp2));
> -               daddr.ip = (__u32) htonl(atoi(temp3));
> +               caddr.ip = (__u32) htonl(strtoul(temp1, NULL, 16));
> +               vaddr.ip = (__u32) htonl(strtoul(temp2, NULL, 16));
> +               daddr.ip = (__u32) htonl(strtoul(temp3, NULL, 16));
>        }
>
>        if (!(cname = addrport_to_anyname(af, &caddr, cport, proto, format)))

Thanks for this fix! I'm sure Vince will release a new version with
this once there is sunlight in his timezone :)

Do you think it'll make sense to host the new ipvsadm on
linuxvirtualserver.org (marked as experimental, of course) when the
Netlink patches go in? This seems more open than hosting it on our
private servers...

Julius

-- 
Google Switzerland GmbH
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html