netdev - Re: [PATCH 1/1] r8169: balance pci_map / pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2008 14:57:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, ilpo.jarvinen@...sinki.fi,
	alistair@...zero.co.uk, tjfontaine@...consulting.com,
	edward_hsu@...ltek.com.tw, ivecera@...hat.com, stable@...nel.org
Subject: Re: [PATCH 1/1] r8169: balance pci_map / pci_unmap pair

On Thu, 21 Aug 2008 23:47:34 +0200
Francois Romieu <romieu@...zoreil.com> wrote:

> The leak hurts with swiotlb and jumbo frames (see
> http://bugzilla.kernel.org/show_bug.cgi?id=9468).
> 
> Heavily hinted by Ilpo J__rvinen <ilpo.jarvinen@...sinki.fi>.
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Tested-by: Alistair John Strachan <alistair@...zero.co.uk>
> Tested-by: Timothy J Fontaine <tjfontaine@...consulting.com>
> Cc: Edward Hsu <edward_hsu@...ltek.com.tw>
> ---
>  drivers/net/r8169.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index a3e3895..0f6f974 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -2792,7 +2792,7 @@ static int rtl8169_rx_interrupt(struct net_device *dev,
>  					pkt_size, PCI_DMA_FROMDEVICE);
>  				rtl8169_mark_to_asic(desc, tp->rx_buf_sz);
>  			} else {
> -				pci_unmap_single(pdev, addr, pkt_size,
> +				pci_unmap_single(pdev, addr, tp->rx_buf_sz,
>  						 PCI_DMA_FROMDEVICE);
>  				tp->Rx_skbuff[entry] = NULL;
>  			}

Also needed in 2.6.25.x and 2.6.26.x, yes?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html