netdev - Re: [PATCH 6/8] Revert "netns: Fix device renaming for sysfs"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080820.234708.193699562.davem@davemloft.net>
Date:	Wed, 20 Aug 2008 23:47:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	greg@...ah.com, gregkh@...e.de, akpm@...ux-foundation.org,
	htejun@...il.com, dlezcano@...ibm.com,
	linux-kernel@...r.kernel.org, viro@....linux.org.uk,
	containers@...ts.osdl.org, benjamin.thery@...l.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 6/8] Revert "netns: Fix device renaming for sysfs"

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Wed, 20 Aug 2008 23:38:31 -0700

> 
> This reverts commit aaf8cdc34ddba08122f02217d9d684e2f9f5d575.
> 
> Drivers like the ipw2100 call device_create_group when they
> are initialized and device_remove_group when they are shutdown.
> Moving them between namespaces deletes their sysfs groups early.
> 
> In particular the following call chain results.
> netdev_unregister_kobject -> device_del -> kobject_del -> sysfs_remove_dir
> With sysfs_remove_dir recursively deleting all of it's subdirectories,
> and nothing adding them back.
> 
> Ouch!
> 
> Therefore we need to call something that ultimate calls sysfs_mv_dir
> as that sysfs function can move sysfs directories between namespaces
> without deleting their subdirectories or their contents.   Allowing
> us to avoid placing extra boiler plate into every driver that does
> something interesting with sysfs.
> 
> Currently the function that provides that capability is device_rename.
> That is the code works without nasty side effects as originally written.
> 
> So remove the misguided fix for moving devices between namespaces.  The
> bug in the kobject layer that inspired it has now been recognized and
> fixed.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html