netdev - Re: [PATCH RFC 08/24] IPVS: Make protocol handler functions support IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48AD6DBB.9030607@hp.com>
Date:	Thu, 21 Aug 2008 09:29:31 -0400
From:	Brian Haley <brian.haley@...com>
To:	Julius Volz <juliusv@...gle.com>
CC:	netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
	horms@...ge.net.au, kaber@...sh.net, vbusam@...gle.com
Subject: Re: [PATCH RFC 08/24] IPVS: Make protocol handler functions support
 IPv6

Julius Volz wrote:
> +void
> +ip_vs_tcpudp_debug_packet(struct ip_vs_protocol *pp,
> +			  const struct sk_buff *skb,
> +			  int offset,
> +			  const char *msg)
> +{
> +#ifdef CONFIG_IP_VS_IPV6
> +	if (skb->protocol == __constant_htons(ETH_P_IPV6))
> +		ip_vs_tcpudp_debug_packet_v6(pp, skb, offset, msg);
> +	else
> +#endif

I don't think you need the __constant_htons() here, just htons() - 
that's what tcp_ipv6.c does.

> +static void
> +ah_debug_packet(struct ip_vs_protocol *pp, const struct sk_buff *skb,
> +		int offset, const char *msg)
> +{
> +#ifdef CONFIG_IP_VS_IPV6
> +	if (skb->protocol == __constant_htons(ETH_P_IPV6))
> +		ah_debug_packet_v6(pp, skb, offset, msg);
> +	else
> +#endif

htons()

> +static void
> +esp_debug_packet(struct ip_vs_protocol *pp, const struct sk_buff *skb,
> +		 int offset, const char *msg)
> +{
> +#ifdef CONFIG_IP_VS_IPV6
> +	if (skb->protocol == __constant_htons(ETH_P_IPV6))
> +		esp_debug_packet_v6(pp, skb, offset, msg);
> +	else
> +#endif

htons()

I think there's more in one of the other patches too.

So why can't you just create one ip_vs_debug_packet_v6() instead of 
these ah and esp ones which are identical?

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html