netdev - Re: atl1: WARNING at net/sched/sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080822165039.21b8732d@osprey.hogchain.net>
Date:	Fri, 22 Aug 2008 16:50:39 -0500
From:	Jay Cliburn <jacliburn@...lsouth.net>
To:	adobriyan@...il.com
Cc:	csnook@...hat.com, netdev@...r.kernel.org
Subject: Re: atl1: WARNING at net/sched/sch_generic.c:221

On Thu, 21 Aug 2008 21:00:07 -0500
Jay Cliburn <jcliburn@...il.com> wrote:

> 
> Does this patch fix it?
> 
> diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
> index e23ce77..4816c6d 100644
> --- a/drivers/net/atlx/atl1.c
> +++ b/drivers/net/atlx/atl1.c
> @@ -1307,7 +1307,6 @@ static u32 atl1_check_link(struct atl1_adapter
> *adapter) if (netif_msg_link(adapter))
>  				dev_info(&adapter->pdev->dev, "link
> is down\n"); adapter->link_speed = SPEED_0;
> -			netif_carrier_off(netdev);
>  		}
>  		return 0;
>  	}
> @@ -1364,8 +1363,6 @@ static u32 atl1_check_link(struct atl1_adapter
> *adapter) /* change original link status */
>  	if (netif_carrier_ok(netdev)) {
>  		adapter->link_speed = SPEED_0;
> -		netif_carrier_off(netdev);
> -		netif_stop_queue(netdev);
>  	}
>  
>  	if (hw->media_type != MEDIA_TYPE_AUTO_SENSOR &&
> @@ -2654,8 +2651,6 @@ static void atl1_down(struct atl1_adapter
> *adapter) 
>  	adapter->link_speed = SPEED_0;
>  	adapter->link_duplex = -1;
> -	netif_carrier_off(netdev);
> -	netif_stop_queue(netdev);
>  
>  	atl1_clean_tx_ring(adapter);
>  	atl1_clean_rx_ring(adapter);
> @@ -3063,8 +3058,6 @@ static int __devinit atl1_probe(struct pci_dev
> *pdev, 
>  	atl1_pcie_patch(adapter);
>  	/* assume we have no link for now */
> -	netif_carrier_off(netdev);
> -	netif_stop_queue(netdev);
>  
>  	init_timer(&adapter->watchdog_timer);
>  	adapter->watchdog_timer.function = &atl1_watchdog;

Alexey,

Please ignore this patch.  It is unsavory fruit borne of abject
ignorance.

Jay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html