netdev - Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48AE8549.6090705@garzik.org>
Date:	Fri, 22 Aug 2008 05:22:17 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Linux-Driver@...gic.com
CC:	netdev@...r.kernel.org
Subject: Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

Ron Mercer wrote:
> Hi Jeff,
> 
> Please find our new 10Gb ethernet driver at the following site:
> 
> ftp://ftp.qlogic.com/outgoing/linux/network/linux/upstream/qlge
> 
> There are two files at this location:
> qlge-aug212008.patch - A full patch that is buildable on the latest netdev/upstream kernel.
> qlge-aug212008.tar.bz2 - A zip file of the source code at drivers/net/qlge/*
> 
> We are targeting this driver for 2.6.28 release.  We look forward to any and all comments.
> 
> Notes:
> 1) The file qlge_mpi.c (Management Port Interface) is mostly stubbed right now but will have functionality to handle setting up wake-on-lan and getting/setting link paramters.
> 2) Please ignore "#ifdef PALLADIUM".  It will be removed going forward as it's currently used for a test platform.

OK, just skimmed the whole thing (i.e. no in-depth analysis of locking, 
etc.)

Initial thoughts...

- its a nice clean driver
- I have not examined the interrupt and completion paths in depth, but 
they looked unusual enough to warrant additional analysis [on my part]. 
  - There are more spinlocks than usual, raising an eyebrow
- The kmap use is interesting
- I also wonder if heavy use of atomic_t might not be more expensive 
than spinlocking a section, then using normal variables.
- want more info on shadow (buffering?) scheme
- are hardware docs or more info available?
- most drivers do not need LICENSE files, is that really necessary?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html