netdev - Re: [PATCH 1/3] LRO: fix return code propogation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080822.032054.254235784.davem@davemloft.net>
Date:	Fri, 22 Aug 2008 03:20:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org, jesse.brandeburg@...el.com
Subject: Re: [PATCH 1/3] LRO: fix return code propogation

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 21 Aug 2008 17:51:24 -0700

> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> LRO code needs to propogate the return values from the netif_rx and
> netif_receive_skb calls specifically to allow drivers that need that
> information to react correctly.  Some places in the code couldn't
> return the result of the upcall to the stack, so I added the dropped
> counter, which just completes the cache line of the stats struct (on
> 64-bit), so shouldn't be a big deal.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Too vague a commit description.

This patch makes a bunch of routines return status codes, but there
is no given example of a precise intended usage.  That part might
be incorrect (the return value isn't actually needed or the code
in question is doing something wrong), which is why providing such
example is important.

So I'm dropping this.  Please provide such info in any resubmission or
I'll just ignore it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html