netdev - Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080822174626.GC2551@susedev.qlogic.org>
Date:	Fri, 22 Aug 2008 10:46:26 -0700
From:	Ron Mercer <ron.mercer@...gic.com>
To:	David Miller <davem@...emloft.net>
Cc:	jeff@...zik.org, Linux-Driver@...gic.com, netdev@...r.kernel.org
Subject: Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

On Fri, Aug 22, 2008 at 02:42:52AM -0700, David Miller wrote:
> From: Jeff Garzik <jeff@...zik.org>
> Date: Fri, 22 Aug 2008 05:22:17 -0400
> 
> > - The kmap use is interesting
> 
> It's so much easier to just always tack on the pages or whatever
> and use __pskb_pull_tail(skb, SOME_MIN_HEADER_LENGTH)

I will look into changing per your suggestion.  This messy section
runs when jumbo frames arrive that aren't TCP/UDP.  I didn't know
about the API you point out.  Thanks very much.

> 
> I also notice that this driver does not do:
> 
> 	skb_reserve(skb, NET_IP_ALIGN);
> 
> on RX packets to get the IP headers properly 4-byte aligned aligned
> after the ethernet header.

The chip currenly has problems with 2-byte aligned receive buffers.
It will be fixed in the next turn.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html