lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Aug 2008 19:24:15 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	rdunlap@...otime.net, toralf.foerster@....de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	jgarzik@...ox.com
Subject: Re: build issue #564 for v2.6.27-rc4 : undefined reference to
 `NS8390p_init'

> For the record, and from memory, there were three patches.

I would go take a look at the archive if I was you: there were bits from
Ingo and others too.

The diff you are looking for however appears to be this, which reverts part
of the follow on patches to the correct original. I shall however refrain
from looking smug because while the original wd patch was right I'm also the
idiot who put the bug back into the tree.

Signed-off-by: Alan 'pass the paper bags' Cox <alan@...hat.com>

--- drivers/net/wd.c~	2008-08-22 19:17:01.000000000 +0100
+++ drivers/net/wd.c	2008-08-22 19:17:01.000000000 +0100
@@ -337,7 +337,7 @@
 #ifdef CONFIG_NET_POLL_CONTROLLER
 	dev->poll_controller = ei_poll;
 #endif
-	NS8390p_init(dev, 0);
+	NS8390_init(dev, 0);
 
 #if 1
 	/* Enable interrupt generation on softconfig cards -- M.U */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists