netdev - Re: incorrect tcp options with window scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2008 20:26:51 -0700
From:	"Adam Langley" <agl@...erialviolet.org>
To:	"Philip Love" <love_phil@....com>
Cc:	netdev@...r.kernel.org
Subject: Re: incorrect tcp options with window scale

On Fri, Aug 22, 2008 at 7:15 PM, Philip Love <love_phil@....com> wrote:
> When window scaling is enabled, but the tcp buffer sizes are small, then the
> tcp SYN packet created will have an incorrect tcp header length. The tcp
> length is calculated assuming that the window scale option will be inserted
> into the tcp header, but since the buffer sizes are too small the window
> scale is not used. Therefore the last 4 bytes of the options in the tcp
> header are left uninitialized.

I suck again.

David, can you hold off on this patch for a day? I think it's correct,
but there might be another similar case with the SYNACKs that I'll
look at once I've slept.

Cheers


AGL

-- 
Adam Langley agl@...erialviolet.org http://www.imperialviolet.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html