netdev - Re: [PATCH] tcp: fix tcp header size miscalculation when window scale is unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080824.174544.244704849.davem@davemloft.net>
Date:	Sun, 24 Aug 2008 17:45:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	agl@...erialviolet.org
Cc:	netdev@...r.kernel.org, love_phil@....com
Subject: Re: [PATCH] tcp: fix tcp header size miscalculation when window
 scale is unused

From: "Adam Langley" <agl@...erialviolet.org>
Date: Sun, 24 Aug 2008 10:40:23 -0700

> From: Philip Love <love_phil@....com>
> 
> tcp: fix tcp header size miscalculation when window scale is unused
> 
> The size of the TCP header is miscalculated when the window scale ends up being
> 0. Additionally, this can be induced by sending a SYN to a passive open port
> with a window scale option with value 0.
> 
> Signed-off-by: Philip Love <love_phil@....com>
> Signed-off-by: Adam Langley <agl@...erialviolet.org>

Adam I really appreciate you're fixing up the patch for Philip, but
how in the world is he ever going to learn how to submit a patch
properly if you just do it for him?

I could have fixed it up too, but I pushed it back so that he learns
how to submit a patch correctly, and this will help him and the rest
of us in the future when he wants to submit other patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html