netdev - Re: [PATCH] tcp: fix tcp header size miscalculation when window scale is unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080825.140752.41921187.davem@davemloft.net>
Date:	Mon, 25 Aug 2008 14:07:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	love_phil@....com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: fix tcp header size miscalculation when window
 scale is unused

From: Phil Love <love_phil@....com>
Date: Mon, 25 Aug 2008 09:30:13 -0700

> Here is the patch using Thunderbird, rather than Apple Mail. Hopefully 
> it is not mangled this time.
> 
> Signed-off-by: Philip Love <love_phil@....com>

Unfortunately it is still mangled.

> --- a/net/ipv4/tcp_output.c	2008-08-24 07:44:18.000000000 -0700
> +++ b/net/ipv4/tcp_output.c	2008-08-24 07:43:05.000000000 -0700
> @@ -468,7 +468,8 @@ static unsigned tcp_syn_options(struct s
>   	}
>   	if (likely(sysctl_tcp_window_scaling)) {
>   		opts->ws = tp->rx_opt.rcv_wscale;
> -		size += TCPOLEN_WSCALE_ALIGNED;
> +		if(likely(opts->ws))
> +			size += TCPOLEN_WSCALE_ALIGNED;
>   	}
>   	if (likely(sysctl_tcp_sack)) {
>   		opts->options |= OPTION_SACK_ADVERTISE;

On those lines of the patch where no changes are occuring there
should be a single space then one or more tab characters.

There are instead two spaces then the tab characters.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html