netdev - Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0808261044120.11710@palito_client100.nuovasystems.com>
Date:	Tue, 26 Aug 2008 10:53:26 -0700 (PDT)
From:	Scott Feldman <scofeldm@...co.com>
To:	Roland Dreier <rdreier@...co.com>
cc:	netdev@...r.kernel.org
Subject: Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS,
 etc

On Mon, 25 Aug 2008, Roland Dreier wrote:

> > +config ENIC
> > +	tristate "Cisco 10Gigabit Ethernet NIC"
>
> The Kconfig file seems to use "10 Gigabit Ethernet" (with a space) or
> variations on "10Gb Ethernet".  Probably worth it not to add yet another
> variation.

done

> > +	depends on PCI
> > +	select INET_LRO
>
> I believe if you select INET_LRO, you'd better depend on INET or else it
> is possible to create unbuildable configs.
>

done
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html