netdev - Re: [Security] [PATCH] sctp: add verification checks to SCTP_AUTH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0808251827240.3363@nehalem.linux-foundation.org>
Date:	Mon, 25 Aug 2008 18:28:32 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Eugene Teo <eteo@...hat.com>
cc:	Vlad Yasevich <vladislav.yasevich@...com>, netdev@...r.kernel.org,
	linux-sctp@...r.kernel.org, security@...nel.org,
	davem@...emloft.net
Subject: Re: [Security] [PATCH] sctp: add verification checks to SCTP_AUTH_KEY
 option



On Mon, 25 Aug 2008, Linus Torvalds wrote:
> 
> But if it can overflow, I actually think it makes more sense to test for 
> something smaller than the "exact" overflow. A key can't reasonably be all 
> that long _anyway_, so it's probably better to test for something _much_ 
> smaller.

IOW, I think it would make _more_ sense to just declare some "key size 
max", and do something like

	#define SCTP_AUTH_KEY_SIZE (65536)

	.. 
	if (key_len > SCTP_AUTH_KEY_SIZE)
		return -EINVAL;

kind of thing.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html