netdev - Re: [PATCH] pkt_sched: Fix dev_graft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080826130536.GC5991@ff.dom.local>
Date:	Tue, 26 Aug 2008 13:05:36 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] pkt_sched: Fix dev_graft_qdisc() locking

On Tue, Aug 26, 2008 at 10:48:13PM +1000, Herbert Xu wrote:
> Jarek Poplawski <jarkao2@...il.com> wrote:
> > pkt_sched: Fix dev_graft_qdisc() locking
> > 
> > During dev_graft_qdisc() dev is deactivated, so qdisc_root_lock()
> > returns wrong lock of noop_qdisc instead of qdisc_sleeping.
> > 
> > 
> > Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
> 
> Looks good to me!
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> 

BTW, I should've probably mention this lock doesn't probably
matter here much, after current precise deactivation.

Thanks,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html