netdev - Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48B545CC.70006@b-bl.de>
Date:	Wed, 27 Aug 2008 14:17:16 +0200
From:	Bastian Bloessl <basti@...l.de>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	Herbert Xu <herbert@...dor.apana.org.au>,
	David Miller <davem@...emloft.net>, jarkao2@...il.com,
	netdev@...r.kernel.org, denys@...p.net.lb,
	Jussi Kivilinna <jussi.kivilinna@...et.fi>,
	jamal <hadi@...erus.ca>
Subject: Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().

Stephen Hemminger wrote:

> 
> Last time I tried TBF(100kbit) { netem(+100ms) } it gave different answers
> than netem(+100ms) { TBF(100kbit) }.  

This might be because in the 2nd case you waste tokens when netem 
requeues to TBF.
But TBFs requeue() can't restore tokens because as David said netem uses 
it to enqueue reordered packets.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html