netdev - Re: cat /proc/net/tcp takes 0.5 seconds on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48B5DE9F.4010000@cosmosbay.com>
Date:	Thu, 28 Aug 2008 01:09:19 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
Cc:	andi@...stfloor.org, davej@...hat.com, netdev@...r.kernel.org,
	j.w.r.degoede@....nl
Subject: Re: cat /proc/net/tcp takes 0.5 seconds on x86_64

David Miller a écrit :
> From: Andi Kleen <andi@...stfloor.org>
> Date: Thu, 28 Aug 2008 00:34:10 +0200
> 
>> It fixes an old performance problem at least. I'm not aware 
>> of any new ones in this area because the code in this 
>> function hasn't changed since I last looked.
> 
> That's exactly what this thread is about, things got slower for
> some reason even though nothing specifically changed in this area.
> 
> I wonder if indirectly something changed in how the hash table
> allocator code down in mm/*.c works, perhaps it's taking NUMA
> into account differently now?
> 

Not really, I suspect commit (a7ab4b501f9b8a9dc4d5cee542db67b6ccd1088b 
[TCPv4]: Improve BH latency in /proc/net/tcp) is responsible for longer delays.
Note that its rather old :
Date:   Sun Jun 10 17:33:08 2007 -0700

We used to disable bh once, while reading the table. This sucked.

In case machine is handling trafic, we now are preemptable by softirqs
while reading /proc/net/tcp. Thats a good thing.

By the way, I find Andi patch usefull. Same thing could be done for /proc/net/rt_cache.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html