netdev - Re: [PATCH] atl1e: multistatement if missing braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48B52054.1000204@garzik.org>
Date:	Wed, 27 Aug 2008 05:37:24 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
CC:	Jie Yang <jie.yang@...eros.com>, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] atl1e: multistatement if missing braces

Ilpo Järvinen wrote:
> Doesn't cause problems (yet) because err gets zeroed earlier.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> ---
>  drivers/net/atl1e/atl1e_main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c
> index 82d7be1..7685b99 100644
> --- a/drivers/net/atl1e/atl1e_main.c
> +++ b/drivers/net/atl1e/atl1e_main.c
> @@ -2232,10 +2232,11 @@ static int atl1e_resume(struct pci_dev *pdev)
>  
>  	AT_WRITE_REG(&adapter->hw, REG_WOL_CTRL, 0);
>  
> -	if (netif_running(netdev))
> +	if (netif_running(netdev)) {
>  		err = atl1e_request_irq(adapter);
>  		if (err)
>  			return err;
> +	}

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html