netdev - Re: [PATCH] ibmveth: fix bad UDP checksums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48B5206D.2010502@garzik.org>
Date:	Wed, 27 Aug 2008 05:37:49 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Santiago Leon <santil@...ibm.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] ibmveth: fix bad UDP checksums

Santiago Leon wrote:
> This patch fixes a ibmveth bug where bad UDP checksums are being transmitted 
> when checksum offloading is enabled.
> The hypervisor does checksum offloading only on TCP packets, so ibmveth calls 
> skb_checksum_help() for any other protocol.  The bug happens because 
> the packet is being modified after the DMA map, so we would need a memory 
> barrier before making the hypervisor call.  Reordering the code so that the 
> DMA map happens after skb_checksum_help() has the additional advantage of 
> fixing a DMA map leak if skb_checksum_help() where to fail.
> 
> Please consider applying.
> 
> Signed-off-by: Santiago Leon <santil@...ibm.com>
> ---
> 
>  ibmveth.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html