netdev - Re: [PATCH 1/2] pkt_sched: Fix gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080827095549.GA12583@gondor.apana.org.au>
Date:	Wed, 27 Aug 2008 19:55:49 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] pkt_sched: Fix gen_estimator locks

On Wed, Aug 27, 2008 at 02:26:33AM -0700, David Miller wrote:
>
> > > @@ -830,9 +830,16 @@ qdisc_create(struct net_device *dev, struct netdev_queue *dev_queue,
> > >                        sch->stab = stab;
> > >                }
> > >                if (tca[TCA_RATE]) {
> > > +                       spinlock_t *root_lock;
> > > +
> > > +                       if ((sch->parent != TC_H_ROOT) &&
> > > +                           !(sch->flags & TCQ_F_INGRESS))
> > > +                               root_lock = qdisc_root_sleeping_lock(sch);
> > > +                       else
> > > +                               root_lock = qdisc_lock(sch);
> > 
> > Another reason why we should just have pointers to the root.
> 
> Yes root pointers would be useful, but they wouldn't kill these tests
> :-)
> 
> Here in qdisc_create() we might be creating the new root, and we'd
> still thus need a conditional for that case.

What I mean is a pointer like sch->root_qdisc, and we would provide
that to qdisc_create as a parameter in place of dev_queue (and
NULL for root qdiscs themselves).  So as long as we assign it at
the top of this function it would be available here too.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html