netdev - Re: [PATCH] ibm_newemac: Don't call dev_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48B524CC.6020309@pobox.com>
Date:	Wed, 27 Aug 2008 05:56:28 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	benh@...nel.crashing.org
CC:	netdev <netdev@...r.kernel.org>,
	linuxppc-dev list <linuxppc-dev@...abs.org>,
	Sebastian Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] ibm_newemac: Don't call dev_mc_add() before device is
 registered

Benjamin Herrenschmidt wrote:
> We must not call dev_mc_add() from within our HW configure which happens
> before we initialize and register the netdev. Do it in open() instead.
> 
> Thanks to Sebastian Siewior for tracking it down. 
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
> 
> This fixes an uninitialized spinlock warning (and possibly more).
> 
> Please apply.

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html