netdev - Re: [patch for 2.6.27? 4/5] forcedeth: fix checksum flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48B52503.8070309@garzik.org>
Date:	Wed, 27 Aug 2008 05:57:23 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org, aabdulla@...dia.com, jgarzik@...ox.com,
	manfred@...orfullife.com, stable@...nel.org
Subject: Re: [patch for 2.6.27? 4/5] forcedeth: fix checksum flag

akpm@...ux-foundation.org wrote:
> From: Ayaz Abdulla <aabdulla@...dia.com>
> 
> Fix the checksum feature advertised in device flags.  The hardware support
> TCP/UDP over IPv4 and TCP/UDP over IPv6 (without IPv6 extension headers). 
> However, the kernel feature flags do not distinguish IPv6 with/without
> extension headers.
> 
> Therefore, the driver needs to use NETIF_F_IP_CSUM instead of
> NETIF_F_HW_CSUM since the latter includes all IPv6 packets.
> 
> A future patch can be created to check for extension headers and perform
> software checksum calculation.
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>
> Cc: Jeff Garzik <jgarzik@...ox.com>
> Cc: Manfred Spraul <manfred@...orfullife.com
> Cc: <stable@...nel.org>		[2.6.25.x, 2.6.26.x]
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

applied, although for future reference, read the top of 
include/linux/skbuff.h, most notably:

  *          NOTE: Even if device supports only some protocols, but
  *          is able to produce some skb->csum, it MUST use COMPLETE,
  *          not UNNECESSARY.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html