netdev - Re: [PATCH 1/2] sctp: correct bounds check in sctp_setsockopt_auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48B5EAE9.9090704@redhat.com>
Date:	Thu, 28 Aug 2008 08:01:45 +0800
From:	Eugene Teo <eteo@...hat.com>
To:	Vlad Yasevich <vladislav.yasevich@...com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, security@...nel.org,
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH 1/2] sctp: correct bounds check in sctp_setsockopt_auth_key

Vlad Yasevich wrote:
> The bonds check to prevent buffer overlflow was not exactly
> right.  It still allowed overflow of up to 8 bytes which is
> sizeof(struct sctp_authkey).
> 
> Since optlen is already checked against the size of that struct,
> we are guaranteed not to cause interger overflow either.
> 
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@...com>

Acked-by: Eugene Teo <eugeneteo@...nel.sg>

Eugene
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html