netdev - [PATCH 3/3] IPROUTE: generate compat messages that match nla_parse_nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080828011347.7987.24759.stgit@jtkirshe-mobile.jf.intel.com>
Date:	Wed, 27 Aug 2008 18:13:47 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	jeff@...zik.org, tgraf@...g.ch
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: [PATCH 3/3] IPROUTE: generate compat messages that match
	nla_parse_nested_compat

From: Alexander Duyck <alexander.h.duyck@...el.com>

This patch updates libnetlink.c to generate nested compat netlink
attributes in the same format that is parsed by the kernels 2.6.26
and newer.

This patch will fix the prio multiqueue option for 2.6.26 kernels,
but will break compatibility with all kernels prior to 2.6.26.

Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---

 lib/libnetlink.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/lib/libnetlink.c b/lib/libnetlink.c
index 5ae64f7..5f42ec1 100644
--- a/lib/libnetlink.c
+++ b/lib/libnetlink.c
@@ -573,7 +573,6 @@ struct rtattr *addattr_nest_compat(struct nlmsghdr *n, int maxlen, int type,
 	struct rtattr *start = NLMSG_TAIL(n);
 
 	addattr_l(n, maxlen, type, data, len);
-	addattr_nest(n, maxlen, type);
 	return start;
 }
 
@@ -582,7 +581,6 @@ int addattr_nest_compat_end(struct nlmsghdr *n, struct rtattr *start)
 	struct rtattr *nest = (void *)start + NLMSG_ALIGN(start->rta_len);
 
 	start->rta_len = (void *)NLMSG_TAIL(n) - (void *)start;
-	addattr_nest_end(n, nest);
 	return n->nlmsg_len;
 }
 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html