netdev - Re: [NET_NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080828.012142.51698124.davem@davemloft.net>
Date:	Thu, 28 Aug 2008 01:21:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	alexander.h.duyck@...el.com
Subject: Re: [NET_NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler
 support

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 27 Aug 2008 18:12:53 -0700

> This patch is intended to add a qdisc to support the new tx multiqueue
> architecture by providing a band for each hardware queue.  By doing
> this it is possible to support a different qdisc per physical hardware
> queue.
> 
> This qdisc uses the skb->queue_mapping to select which band to place
> the traffic onto.  It then uses a round robin w/ a check to see if the
> subqueue is stopped to determine which band to dequeue the packet from.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

It looks mostly fine.

But I wonder how useful this "bands" parameter is.
It behaves as follows:

1) "1" is always allowed, essentially non-multiqueue
2) ->real_num_tx_queues is always allowed
3) 0 means auto detect, which is also ->real_num_tx_queues

Everything else is rejected.

It's effectively a boolean, use all the TX queues or just one.  So
maybe that's how it should be presented and implemented.

That makes sense because the user has no way to figure out how many TX
queues are currently available.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html