netdev - Re: [PATCH 3/3] IPROUTE: generate compat messages that match nla_parse_nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080828095131.GX20815@postel.suug.ch>
Date:	Thu, 28 Aug 2008 11:51:31 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, davem@...emloft.net,
	Alexander Duyck <alexander.h.duyck@...el.com>
Subject: Re: [PATCH 3/3] IPROUTE: generate compat messages that match nla_parse_nested_compat

* Jeff Kirsher <jeffrey.t.kirsher@...el.com> 2008-08-27 18:13
> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This patch updates libnetlink.c to generate nested compat netlink
> attributes in the same format that is parsed by the kernels 2.6.26
> and newer.
> 
> This patch will fix the prio multiqueue option for 2.6.26 kernels,
> but will break compatibility with all kernels prior to 2.6.26.

I'm not sure what you mean by fix, I can't find any nested attributes
being parsed in the proposed sch_multiq.c.

Wouldn't it be simpler to have q_multiq.c use addattr_nest() instead of
addattr_nest_compat() instead of changing addattr_nest_compat() to be
equivalent to addattr_nest()?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html