netdev - Re: [PATCH 14/37] dccp: Tidy up setsockopt calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28fa9c5e0808290225w1d2a2ff7kf4fb63741780c091@mail.gmail.com>
Date:	Fri, 29 Aug 2008 17:25:53 +0800
From:	"Eugene Teo" <eugeneteo@...nel.sg>
To:	"Gerrit Renker" <gerrit@....abdn.ac.uk>
Cc:	dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 14/37] dccp: Tidy up setsockopt calls

On Fri, Aug 29, 2008 at 1:44 AM, Gerrit Renker <gerrit@....abdn.ac.uk> wrote:
[...]
> +       default:
> +               if (optlen < sizeof(int))
> +                       return -EINVAL;

Although it is already checked in sys_setsockopt(), it's probably good
to change this to:

               if (optlen < (int)sizeof(int))
                       return -EINVAL;

Reviewed-by: Eugene Teo <eugeneteo@...nel.sg>

Thanks, Eugene
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html