netdev - Re: [PATCH 2/2] ne.c msleep not mdelay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080830154447.770aaca0@lxorguk.ukuu.org.uk>
Date:	Sat, 30 Aug 2008 15:44:47 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	david@...es.net, linux-kernel@...r.kernel.org,
	p_gortmaker@...oo.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ne.c msleep not mdelay

> There are already some msleep() in probe_irq_on() which is called just
> before here.  And this part is not protected by any spinlock or
> preempt_disable.
> 
> So, if rescheduling was dangerous here, we already have potential
> problems, no?

Yes we do but I didn't manage to stop the other mistakes getting in when
they did. If you take a schedule you get results back from the probe_irq
that tend to suck in other random ISA device events (ISA being edge
triggered nobody was ever careful about spurious irq)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html