netdev - Re: [NET_NEXT PATCH 2/2] pkt_action: add new action skbedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9929d2390808292247r116d26b2y9bf995d92d00d2d0@mail.gmail.com>
Date:	Fri, 29 Aug 2008 22:47:16 -0700
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Bill Fink" <billfink@...dspring.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, davem@...emloft.net,
	"Alexander Duyck" <alexander.h.duyck@...el.com>
Subject: Re: [NET_NEXT PATCH 2/2] pkt_action: add new action skbedit

On Fri, Aug 29, 2008 at 8:13 PM, Bill Fink <billfink@...dspring.com> wrote:
> On Wed, 27 Aug 2008, Jeff Kirsher wrote:
>
>> From: Alexander Duyck <alexander.h.duyck@...el.com>
>>
>> This new action will have the ability to change the priority and/or
>> queue_mapping fields on an sk_buff.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> ---
>>
>>  include/linux/tc_act/tc_skbedit.h |   23 ++++
>>  include/net/tc_act/tc_skbedit.h   |   15 +++
>>  net/sched/Kconfig                 |   11 ++
>>  net/sched/Makefile                |    1
>>  net/sched/act_skbedit.c           |  199 +++++++++++++++++++++++++++++++++++++
>>  5 files changed, 249 insertions(+), 0 deletions(-)
>>  create mode 100644 include/linux/tc_act/tc_skbedit.h
>>  create mode 100644 include/net/tc_act/tc_skbedit.h
>>  create mode 100644 net/sched/act_skbedit.c
>
>> diff --git a/net/sched/Kconfig b/net/sched/Kconfig
>> index efaa7a7..613823b 100644
>> --- a/net/sched/Kconfig
>> +++ b/net/sched/Kconfig
>> @@ -485,6 +485,17 @@ config NET_ACT_SIMP
>>         To compile this code as a module, choose M here: the
>>         module will be called simple.
>>
>> +config NET_ACT_SKBEDIT
>> +        tristate "SKB Editing"
>> +        depends on NET_CLS_ACT
>> +        ---help---
>> +       Say Y here to change skb priority or queue_mapping settings.
>> +
>> +       If unsure, say N.
>> +
>> +       To compile this code as a module, choose M here: the
>> +       module will be called simple.
>> +
>>  config NET_CLS_IND
>>       bool "Incoming device classification"
>>       depends on NET_CLS_U32 || NET_CLS_FW
>
> I'm rather backlogged on e-mail at the moment, so apologies if someone
> else already pointed this out, but I'm guessing there was a copy and
> paste error here, as the module shouldn't be called simple (that's for
> the preceding NET_ACT_SIMP).
>
>                                                -Bill
>

Nice catch.  I was just about to post an updated patch set from Alex,
and it was a good thing I checked mail before sending the patches out.

I have corrected this in the next patch set (coming in about 10 minutes).

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html