netdev - Re: [PATCHv2 RFC 16/25] IPVS: Add/adjust Netfilter hook functions and helpers for v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080902074049.GH13730@verge.net.au>
Date:	Tue, 2 Sep 2008 17:40:51 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Julius Volz <juliusv@...gle.com>
Cc:	netdev@...r.kernel.org, lvs-devel@...r.kernel.org, kaber@...sh.net,
	vbusam@...gle.com
Subject: Re: [PATCHv2 RFC 16/25] IPVS: Add/adjust Netfilter hook functions
	and helpers for v6

On Mon, Sep 01, 2008 at 02:56:13PM +0200, Julius Volz wrote:
> Add Netfilter hook functions or modify existing ones, if possible, to
> process IPv6 packets. Some support functions are also added/modified for
> this. ip_vs_nat_icmp_v6() was already added in the patch that added the v6
> xmit functions, as it is called from one of them.
> 
> Signed-off-by: Julius Volz <juliusv@...gle.com>

Please run checkpatch.pl over this patch.

>  1 files changed, 326 insertions(+), 36 deletions(-)
> 
> diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c
> index 8bfd7c2..0bf871c 100644
> --- a/net/ipv4/ipvs/ip_vs_core.c
> +++ b/net/ipv4/ipvs/ip_vs_core.c
> @@ -39,6 +39,11 @@
>  #include <linux/netfilter.h>
>  #include <linux/netfilter_ipv4.h>
>  
> +#ifdef CONFIG_IP_VS_IPV6
> +#include <net/ipv6.h>
> +#include <linux/netfilter_ipv6.h>
> +#endif
> +
>  #include <net/ip_vs.h>
>  
>  
> @@ -60,6 +65,7 @@ EXPORT_SYMBOL(ip_vs_get_debug_level);
>  
>  /* ID used in ICMP lookups */
>  #define icmp_id(icmph)          (((icmph)->un).echo.id)
> +#define icmpv6_id(icmph)        (icmph->icmp6_dataun.u_echo.identifier)

Should this be ((icmph)->icmp6_dataun.u_echo.identifier) ?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html