lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48BE97BF.7010909@garzik.org>
Date:	Wed, 03 Sep 2008 09:57:19 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Wang Chen <wangchen@...fujitsu.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	NETDEV <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/15] netdevice 82596: Convert directly reference of netdev->priv
 to netdev_priv()

Wang Chen wrote:
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> ---
>  drivers/net/82596.c |   28 ++++++++++++++--------------
>  1 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/net/82596.c b/drivers/net/82596.c
> index da292e6..6b14dd2 100644
> --- a/drivers/net/82596.c
> +++ b/drivers/net/82596.c
> @@ -457,7 +457,7 @@ static inline int wait_cfg(struct net_device *dev, struct i596_cmd *cmd, int del
>  
>  static void i596_display_data(struct net_device *dev)
>  {
> -	struct i596_private *lp = dev->priv;
> +	struct i596_private *lp = dev->ml_priv;
>  	struct i596_cmd *cmd;
>  	struct i596_rfd *rfd;
>  	struct i596_rbd *rbd;
> @@ -527,7 +527,7 @@ static irqreturn_t i596_error(int irq, void *dev_id)
>  
>  static inline void init_rx_bufs(struct net_device *dev)
>  {
> -	struct i596_private *lp = dev->priv;
> +	struct i596_private *lp = dev->ml_priv;
>  	int i;
>  	struct i596_rfd *rfd;
>  	struct i596_rbd *rbd;

Your code changes and description do not match...  did you intend 
ml_priv or netdev_priv() ?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ