netdev - Re: tipc on sparc32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080902.232627.209816179.davem@davemloft.net>
Date:	Tue, 02 Sep 2008 23:26:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	tipc-discussion@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: tipc on sparc32

From: David Miller <davem@...emloft.net>
Date: Tue, 02 Sep 2008 23:12:01 -0700 (PDT)

> From: Andrew Morton <akpm@...ux-foundation.org>
> Date: Tue, 2 Sep 2008 22:40:59 -0700
> 
> > sparc32 allmodconfig:
> > 
> > In file included from net/tipc/link.h:43,
> >                  from net/tipc/bcast.c:41:
> > net/tipc/node.h:71: error: redefinition of 'struct node'
> > 
> > sparc32 likes catching code which uses insufficiently cautiously chosen
> > identifiers.  dlm is presently blowing up on sparc32 because it has a
> > to_node() function.
> > 
> > Arguably, sparc32 should be fixed, but I'd suggest that random bits of
> > networking code should not be using identifiers as generic-sounding as "node".
> 
> I'll fix sparc for the time being, thanks.

Actually, the conflict is between the include/linux/node.h which the
generic device layer uses, and TIPC.

This isn't a sparc specific problem.

And the DLM issue is the same thing.

It might be triggering on sparc32 because linux/node.h gets included
in the tangle of arch and non-arch include files that happen during
the build, but that's benign as far as blaming sparc is concerned.

I can take care of TIPC.

Andrew can you take a stab at DLM?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html