netdev - Re: [PATCH 21/25] netns ct: per-netns event cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48C013BE.3060800@trash.net>
Date:	Thu, 04 Sep 2008 18:58:38 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	adobriyan@...il.com
CC:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	containers@...ts.linux-foundation.org
Subject: Re: [PATCH 21/25] netns ct: per-netns event cache

adobriyan@...il.com wrote:
>  static inline void
> -nf_conntrack_event_cache(enum ip_conntrack_events event,
> +nf_conntrack_event_cache(struct net *net, enum ip_conntrack_events event,
>  			 const struct sk_buff *skb)
>  {

Passing the conntrack instead of the struct net and the skb
would probably keep the callers cleaner.

>  	struct nf_conn *ct = (struct nf_conn *)skb->nfct;
>  	struct nf_conntrack_ecache *ecache;
>  
>  	local_bh_disable();
> -	ecache = &__get_cpu_var(nf_conntrack_ecache);
> +	ecache = per_cpu_ptr(net->ct.ecache, raw_smp_processor_id());
>  	if (ct != ecache->ct)
>  		__nf_ct_event_cache_init(ct);
>  	ecache->events |= event;
> @@ -60,16 +58,29 @@ nf_ct_expect_event(enum ip_conntrack_expect_events event,
>  	atomic_notifier_call_chain(&nf_ct_expect_chain, event, exp);
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html