netdev - Re: [RFC PATCH v4 02/14] selinux: Better local/forward check in selinux_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200809051758.35242.paul.moore@hp.com>
Date:	Fri, 5 Sep 2008 17:58:35 -0400
From:	Paul Moore <paul.moore@...com>
To:	James Morris <jmorris@...ei.org>
Cc:	selinux@...ho.nsa.gov, netdev@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: [RFC PATCH v4 02/14] selinux: Better local/forward check in selinux_ip_postroute()

On Friday 05 September 2008 4:51:46 am James Morris wrote:
> On Tue, 2 Sep 2008, Paul Moore wrote:
> > It turns out that checking to see if skb->sk is NULL is not a very
> > good indicator of a forwarded packet as some locally generated
> > packets also have skb->sk set to NULL.  Fix this by not only
> > checking the skb->sk field but also the IP[6]CB(skb)->flags field
> > for the IP[6]SKB_FORWARDED flag.
> >
> > Signed-off-by: Paul Moore <paul.moore@...com>
> > ---
> >
> >  security/selinux/hooks.c |   36
> > +++++++++++++++++++++++++++--------- 1 files changed, 27
> > insertions(+), 9 deletions(-)
>
> Acked-by: James Morris <jmorris@...ei.org>

Thanks for taking the time to review the patches and send feedback, I 
know they weren't small.  I've made all the corrections you've 
suggested as well as the ones that Andrew and Randy pointed out.  I'm 
building a new kernel to test right now, if all goes well I'll push the 
new bits tonight or tomorrow.

I've also added all your ACKs to their respective patches except for 
this one because I made some non-trivial changes and didn't think it 
was fair to use your ACK.  While I was looking at the code I realized 
that we are calling selinux_parse_skb() in the per-packet processing 
functions a bit too early (my fault) resulting in potentially wasted 
cycles.  I've fixed it in this patch and you'll see the change 
shortly ...

-- 
paul moore
linux @ hp
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html