netdev - Re: [PATCH 1/1] niu: panic on reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080908.132031.65821182.davem@davemloft.net>
Date:	Mon, 08 Sep 2008 13:20:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Santwona.Behera@....COM
Cc:	netdev@...r.kernel.org, Matheos.Worku@....COM, agospoda@...hat.com
Subject: Re: [PATCH 1/1] niu: panic on reset

From: Santwona.Behera@....COM
Date: Thu, 04 Sep 2008 16:55:16 -0700

[ Please learn how to hit the return key every 80 characters or so,
  long lines are very difficult to read on text-only email clients
  like the one I use.  Expecting auto-formatting and other beautifications
  in email readers amongst kernel developers is a very bad idea. ]

> The reset_task function in the niu driver does not reset the
> hardware fully. The buffer addresses and pointers are not being
> reset/updated in the hardware and that leads to panic on reset.
>
> Signed-off-by: santwona.behera@....com <santwona.behera@....com>

This is way overkill just to fix this bug and it adds a new failure
mode for the driver which is a seriously negative aspect to this fix.

Instead, simply write a function which reloads the buffers addresses
properly instead of calling the functions to free and reallocate all
of these dynamic datastructures just to get those side effects.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html