netdev - Re: [PATCH -mm] Fix dev_load() compilation again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080908151707.21cd1c6c.akpm@linux-foundation.org>
Date:	Mon, 8 Sep 2008 15:17:07 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	adobriyan@...il.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, sfr@...b.auug.org.au,
	Johannes Berg <johannes@...solutions.net>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH -mm] Fix dev_load() compilation again

On Fri, 05 Sep 2008 12:54:51 -0700
Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:

> Alexey Dobriyan wrote:
> > dev_load() doesn't exist if MODULES=n.
> 
> Hi,
> 
> in -next tree, this patch fixes the compilation error instead of
> my patch. So, there is a conflict.
> 
> commit 9b90dc7bc3079376567fc501e2e84751fa4040fd
> Author: Stephen Rothwell <sfr@...b.auug.org.au>
> Date:   Wed Aug 27 14:45:37 2008 +1000
> 
>     rr: build fix for remove CONFIG_KMOD from net
> 
>     Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> 

Give that there's already a fix in linux-next, I can't do anything here.

Rusty, the regression was introduced by

commit 4cb9da6ecc2b0e25056b45981239475f8509d59d
Author:     Johannes Berg <johannes@...solutions.net>
AuthorDate: Wed Jul 9 10:28:42 2008 +0200
Commit:     Stephen Rothwell <sfr@...b.auug.org.au>
CommitDate: Tue Aug 26 10:19:47 2008 +1000

    remove CONFIG_KMOD from net
    
    Some code here depends on CONFIG_KMOD to not try to load
    protocol modules or similar, replace by CONFIG_MODULES
    where more than just request_module depends on CONFIG_KMOD
    and and also use try_then_request_module in ebtables.
    
    Signed-off-by: Johannes Berg <johannes@...solutions.net>
    Cc: netdev@...r.kernel.org
    Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

Could you please take care of getting it fixed up?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html