netdev - Re: [rfc 1/3] ipvs: handle PARTIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080908072439.GA27257@gondor.apana.org.au>
Date:	Mon, 8 Sep 2008 17:24:40 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Simon Horman <horms@...ge.net.au>
Cc:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	Siim PÃµder <siim@...rad-teel.net>,
	Julian Anastasov <ja@....bg>,
	Malcolm Turnbull <malcolm@...dbalancer.org>,
	Julius Volz <juliusv@...gle.com>,
	Vince Busam <vbusam@...gle.com>
Subject: Re: [rfc 1/3] ipvs: handle PARTIAL_CHECKSUM

On Mon, Sep 08, 2008 at 12:04:21PM +1000, Simon Horman wrote:
>
>  	/* Adjust TCP checksums */
> -	if (!cp->app && (tcph->check != 0)) {
> +	if (skb->ip_summed == CHECKSUM_PARTIAL) {
> +		tcp_partial_csum_update(cp->af, tcph, &cp->daddr, &cp->vaddr,
> +					htonl(oldlen),
> +					htonl(skb->len - tcphoff));

I don't know what cp->app is but should we be updating the checksum
when it's set? The previous code seems to want to compute a full
checksum instead.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html