netdev - Re: xfrm_state locking regression...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080910040107.GA29695@gondor.apana.org.au>
Date:	Wed, 10 Sep 2008 14:01:07 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	timo.teras@....fi, netdev@...r.kernel.org
Subject: Re: xfrm_state locking regression...

On Tue, Sep 09, 2008 at 08:38:08PM -0700, David Miller wrote:
>
> No problem.  It might be a little bit of a chore because this new
> walker design is intimately tied to the af_key non-atomic dump
> changes.

Actually I was mistaken as to how the original dump worked.  I'd
thought that it actually kept track of which bucket it was in and
resumed from that bucket.  However in reality it only had a global
counter and would always start walking from the beginning up until
the counted value.  So it isn't as easy as just copying the old
code across :)

While it is possible to restore the old order and save a little
bit of memory, I certainly don't think this is very urgent.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html