netdev - Re: [PATCH 1/1] niu: panic on reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080910.132808.242997035.davem@davemloft.net>
Date:	Wed, 10 Sep 2008 13:28:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Matheos.Worku@....COM
Cc:	Santwona.Behera@....COM, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] niu: panic on reset

From: Matheos Worku <Matheos.Worku@....COM>
Date: Wed, 10 Sep 2008 10:01:42 -0700

> Instead of creating a new function, Santwona was borrowing an existing
> logic from niu_change_mtu function. Rather than introducing a new
> function and possibly a new failure mode, we were trying to re-use existing
> logic, reducing the probability of a new bug.

But in essence the patch does add a new failure mode.  It now can fail
if a memory allocation cannot succeed at the current point in time.

That was not true previously, and if you just fix up the buffer pointers
or whatever state to be reset, you won't have this possible failure mode
either.

We should fix this correctly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html