netdev - Re: [PATCH 2/4] atlx: add atl2.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48C72D0F.6020803@redhat.com>
Date:	Tue, 09 Sep 2008 22:12:31 -0400
From:	Chris Snook <csnook@...hat.com>
To:	Jay Cliburn <jcliburn@...il.com>
CC:	jeff@...zik.org, netdev@...r.kernel.org,
	atl2-test@...ts.sourceforge.net
Subject: Re: [PATCH 2/4] atlx: add atl2.h

Jay Cliburn wrote:
> On Tue, 9 Sep 2008 02:19:45 -0400
> Chris Snook <csnook@...hat.com> wrote:
> 
>> From: Chris Snook <csnook@...hat.com>
>>
>> Header file for atl2 support.
>>
>> Signed-off-by: Chris Snook <csnook@...hat.com>
> 
> Checkpatch.pl reports some coding style and whitespace issues.  
> 
> total: 83 errors, 46 warnings, 482 lines checked

Wow, that's actually better than I was expecting.  I'm posting it as-is because 
it's ridiculous for people to wait yet another release for this to hit mainline, 
just for cosmetic reasons.  People are using this driver all over the place, and 
nobody is working on fixing the initialization bugs and implementing ethtool 
ioctls while it's sitting in my kscope window waiting for me to clean up the 
rest of the whitespace.

I recommend we merge it anyway, though I admit it needs cleanup.

-- Chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html