netdev - Re: [PATCH 1/1] tg3: Avoid Send BD corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1221173758.12785.32.camel@HP1>
Date:	Thu, 11 Sep 2008 15:55:58 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	"Matthew Carlson" <mcarlson@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"andy@...yhouse.net" <andy@...yhouse.net>
Subject: Re: [PATCH 1/1] tg3: Avoid Send BD corruption


On Thu, 2008-09-11 at 14:51 -0700, David Miller wrote:
> From: "Matt Carlson" <mcarlson@...adcom.com>
> Date: Thu, 11 Sep 2008 09:59:13 -0700
> 
> > On Wed, Sep 10, 2008 at 10:46:18PM -0700, David Miller wrote:
> > > Are users really hitting this or was this discovered by your own
> > > internal testing and verification?
> >
> > The bug was discovered by our own internal testing, but this bug is
> > severe enough to warrant submission to the net-2.6 kernel.  I'll be
> > sending a patch to stable as well.
> >
> > These chips are relatively new so there isn't a whole lot of opportunity
> > for users to experience the problem yet.  As the chips are distributed,
> > the likelyhood that users will encounter this problem is pretty high.
> 
> That doesn't matter.  That isn't the criteria for inclusion outside of
> the merge window, or into -stable.

Send BD corruption is quite serious as it can cause tg3_tx() to crash.
We've seen a number of similar crashes over the years caused by
re-ordered IOs and the nr_frags getting modified by HTB.

Since regression/security/oops fixes are allowed, shouldn't this qualify
since it prevents a crash in tg3_tx()?

> 
> You should read postings such as the following one and the other ones
> in it's thread so that you can become familiar with the criteria:
> 
>         http://marc.info/?l=linux-netdev&m=122048757705315&w=2
> 
> And by those descriptions, this patch is not appropriate and I'm
> therefore not going to try and submit it for 2.6.27 and risk getting
> my head chopped off by Linus again in public.
> 
> 
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html