netdev - [NET-NEXT PATCH] multiq: remove root-only requirement from multiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080912223600.6498.54511.stgit@jtkirshe-mobile.jf.intel.com>
Date:	Fri, 12 Sep 2008 15:36:00 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: [NET-NEXT PATCH] multiq: remove root-only requirement from multiq_tune

From: Alexander Duyck <alexander.h.duyck@...el.com>

This patch removes the root-only requirement for the multiq qdisc so that
you can have prio as a parent if you wish.  This may lead to some odd
behaviors when parent qdiscs are not multiqueue aware.

Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---

 net/sched/sch_multiq.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c
index ce00df4..49a8b67 100644
--- a/net/sched/sch_multiq.c
+++ b/net/sched/sch_multiq.c
@@ -202,8 +202,6 @@ static int multiq_tune(struct Qdisc *sch, struct nlattr *opt)
 	struct tc_multiq_qopt *qopt;
 	int i;
 
-	if (sch->parent != TC_H_ROOT)
-		return -EINVAL;
 	if (!netif_is_multiqueue(qdisc_dev(sch)))
 		return -EINVAL;
 	if (nla_len(opt) < sizeof(*qopt))

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html