netdev - Re: [PATCH 1/2] [PATCH] ne.c fix rmmod, platform driver improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080914.001300.15242170.anemo@mba.ocn.ne.jp>
Date:	Sun, 14 Sep 2008 00:13:00 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	david@...es.net
Cc:	paul.gortmaker@...il.com, akpm@...ux-foundation.org,
	p_gortmaker@...oo.com, alan@...rguk.ukuu.org.uk, jeff@...zik.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] [PATCH] ne.c fix rmmod, platform driver
 improvements

On Sat, 13 Sep 2008 09:44:57 -0500, David Fries <david@...es.net> wrote:
> I reformatted your patch and added a comment.  Does this work for you?
> 
> diff --git a/drivers/net/ne.c b/drivers/net/ne.c
...
>  	/* Update with any values found by probing. */
> -	io[this_dev] = dev->base_addr;
> -	irq[this_dev] = dev->irq;
> +	if (0 <= this_dev && this_dev < MAX_NE_CARDS) {
> +		io[this_dev] = dev->base_addr;
> +		irq[this_dev] = dev->irq;
> +	}
>  	return 0;
>  }

For now rbtx49xx ne platform devices use -1 for pdev->id, but it may
change.  Please don't assume it.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html